mirror of
https://github.com/NVIDIA/OpenShell.git
synced 2026-10-20 06:00:06 +08:00
* chore(providers): remove dead provider plugin modules Twelve modules under crates/openshell-providers/src/providers/ were never declared in providers/mod.rs, so they have not been compiled since the plugin registry was narrowed to the two adapters it still registers. Four of them (generic, gitlab, opencode, outlook) key off provider type identifiers that normalize_provider_type already retired. Keep google_cloud and vertex, which are the only plugins ProviderRegistry::new registers. Signed-off-by: Philippe Martin <phmartin@redhat.com> * test(providers): load example profiles from providers/ at test time Add an example_profiles module that reads the YAML under providers/ from the source checkout at run time and parses it with the existing profile loader. It is gated behind a new non-default example-profiles feature so it is available to this crate's own tests and, once wired into dev-dependencies, to gateway and CLI tests, while never reaching a release binary. Nothing consumes it yet; later changes move the test fixtures off the compiled catalog and onto these files. Signed-off-by: Philippe Martin <phmartin@redhat.com> * test: source profile fixtures from providers/ instead of the compiled catalog Unit and integration fixtures reached into builtin_profiles() to get a profile to work with, which ties the tests to the compiled catalog rather than to the files an operator would import. Point them at the example_profiles loader instead. The profiles.rs tests keep their coverage unchanged and become explicit golden tests over providers/*.yaml: they are what keeps those files valid once nothing compiles them. builtin_profiles_are_sorted_by_id widens into a test that the whole example set parses, sorts, and lints clean as one catalog. The CLI fake gateways serve the example profiles the way a real gateway serves what an operator imported, through a shared helper. No behavior change: the gateway still loads the built-in source by default and serves the same profiles. Signed-off-by: Philippe Martin <phmartin@redhat.com> * docs(providers): document the example provider profiles Each file under providers/ now opens with a header naming its expected client binary identities, the image layout those paths assume, the credential scope, the endpoint access it grants, and a smoke test. Add a README covering the import commands and why a profile should be copied and edited rather than imported unchanged. Several of these profiles bind network access to paths that only exist in the OpenShell Community image — /sandbox/.venv, /app/.venv, /sandbox/.cursor-server, /usr/lib/node_modules. Imported unchanged into another image the profile matches nothing: the catalog still advertises it, but the credential is never injected and the traffic is denied. The headers say so where it applies. Comments only; the profile schema has no documentation fields and all fifteen files still lint clean. Signed-off-by: Philippe Martin <phmartin@redhat.com> * test(server): seed unit-test state with the example provider profiles Server unit tests inherited the builtin + user source default from ServerState, so around a hundred and forty assertions about github, openai and the rest resolved against the compiled catalog. Point the test state at the user source alone and import the example profiles from providers/ into its store first, the way an operator would. Every one of those assertions keeps passing unchanged, which is the point: it proves the gateway behaves identically with an imported catalog before the default moves. Four tests asserted builtin-source semantics specifically. Under import-only the only profiles a gateway cannot edit are the ones a non-user source vends, so they now exercise a source-managed profile composed with the user source; the read-only guard they cover is the one that still applies to interceptor catalogs. The list test asserts the imported profile's user/platform identity instead of builtin with an empty scope. test_server_state_with_user_only_github_profile is gone: the default test state now is a user-only gateway with github imported. Signed-off-by: Philippe Martin <phmartin@redhat.com> * refactor(cli): resolve credential suggestions from the gateway catalog The --env credential warning scanned a profile table compiled into the CLI, so its suggestions described the binary rather than the gateway the user is talking to: a profile the gateway does not serve was suggested anyway, and an imported custom profile never was. Fetch the catalog from the connected gateway instead. The warning moves out of argument parsing and into sandbox create and sandbox template create, where a client already exists. A catalog fetch failure is not fatal — the warning degrades to its generic form rather than blocking sandbox creation. Extract the ListProviderProfiles paging loop from provider list-profiles into a shared fetch_provider_profile_catalog, which the profile-driven paths now share. Signed-off-by: Philippe Martin <phmartin@redhat.com> * refactor(cli)!: infer providers from the gateway catalog Command-to-provider inference went through a hardcoded alias table in openshell-providers, a second copy of the built-in catalog's identifiers. A custom profile could never be inferred no matter what binaries it declared, and the table drifted from the profiles it mirrored. Infer from the connected gateway's catalog instead: match the command's basename against each profile's ID and against the basenames of the binaries the profile authorizes. A profile that names /usr/bin/claude is the profile for running claude. The match must be unique — where several profiles claim a command, the user names one with --provider — and an empty catalog infers nothing. No command is special-cased. `binaries` is the operator's authorization statement, so a profile that declares a binary claims the command that runs it, whatever that binary is; narrowing that belongs in the profile rather than in a list compiled into the CLI, which could never cover an unbounded catalog anyway. Breaking: the retired aliases stop resolving, and commands the old table never listed can now infer. git, pip and uv are declared by the github and pypi example profiles, so they infer where they previously did not. Signed-off-by: Philippe Martin <phmartin@redhat.com> * refactor(providers,server)!: resolve provider profiles by exact ID normalize_provider_type was a hardcoded alias map — gh to github, claude to claude-code, vertex to google-vertex-ai — and a second copy of the built-in catalog's identifiers, independent of the YAML it mirrored. It let a provider type resolve to a profile the operator never named, and it made the built-in IDs behave as a reserved namespace. Remove it, along with detect_provider_from_command and the alias-normalizing ProviderRegistry::inject_env. A provider type now names a profile exactly: - the effective catalog resolves an ID or reports it absent, with no alias retry - plugins activate only for the ID of a profile the gateway resolved; a provider with no resolvable profile gets no plugin projection, instead of falling back to an alias guess - the CLI surfaces the gateway's not-found instead of retrying under an alias - telemetry buckets by profile ID, and the gitlab, opencode and outlook buckets go with the aliases that were their only source Breaking: `--type gh`, `--type claude` and the other aliases no longer resolve. Use the profile's own ID. Signed-off-by: Philippe Martin <phmartin@redhat.com> * feat(server): fail closed when a provider's profile is absent A sandbox composed from a provider whose profile the gateway cannot resolve started anyway: the credential and policy builders warned and skipped, so the sandbox came up carrying none of that provider's credentials or network policy. The operator learned about it later, as a denied connection or a missing environment variable, rather than as the configuration error it is. Check at the two composition boundaries — CreateSandbox and AttachSandboxProvider — right beside the catalog snapshot already taken there, and reject with a bounded diagnostic naming the provider, the profile it refers to, and the import command that supplies it. Scope-aware: a platform-scoped provider is told to import with --global. Read paths are untouched. ListProviders, GetProvider and profile export keep working so an operator can see and recover an affected provider, and the shared policy builders keep their warn-and-skip for the diagnostic paths that also reach them. Signed-off-by: Philippe Martin <phmartin@redhat.com> * refactor(server): scope the vendor base-URL pin to declared endpoints provider_profile_endpoints_are_active withheld a credential and the provider's policy layer when an openai or anthropic provider pointed its client somewhere other than the public vendor endpoint. The guard was keyed on profile.source == "builtin" and on those two profile IDs, so it protected only profiles OpenShell shipped. Once profiles are import-only no profile is ever builtin, and the guard would silently stop applying — including to an operator who imported providers/openai.yaml verbatim. Key it on the profile instead of on where the profile came from. A profile's endpoints are the boundary its credential is bound to, so if the provider configures a *_BASE_URL pointing at a host the profile does not declare, the profile no longer describes where that credential goes and is treated as endpointless. Host matching reuses the DNS-label-aware matcher in openshell-core, so wildcard endpoints such as Vertex's *-aiplatform.googleapis.com resolve correctly. A profile with no declared endpoints has no boundary to contradict, and a config value that names no host is not a redirect this can reason about. Both keep the profile active. The control now covers every endpoint-bearing profile, including an operator's own, and the last "builtin" string leaves the gateway. Signed-off-by: Philippe Martin <phmartin@redhat.com> * test(e2e): import example provider profiles during gateway bring-up The e2e suites create providers from github, openai, nvidia, claude-code and google-cloud, and the GitHub lane runs a real git clone through the profile's binary attribution. A gateway serves only the profiles an operator imported, so the lanes have to import them. Add e2e_import_example_provider_profiles to the shared bring-up helpers and call it from the Docker, Podman, Kubernetes and VM wrappers once the gateway is healthy and registered. It runs the same command the upgrade notes give operators, against the repository's own providers/ directory, so the lanes exercise the documented path rather than a test-only shortcut. Lands before the default changes: a same-ID user profile already shadows a built-in, so importing works today. Signed-off-by: Philippe Martin <phmartin@redhat.com> * refactor(providers)!: make provider profiles import-only OpenShell compiled fifteen provider profile YAML files into every release binary and selected them by default, so a fresh gateway published a catalog it was never configured with. Those profiles are not image-neutral: their binary selectors name paths that exist in the OpenShell Community image, so changing the sandbox image could make a profile inert while the catalog still advertised it. Every endpoint, credential name and binary path in providers/ was also effectively part of the 0.1.0 public contract. A gateway's catalog is now exactly what an operator imported: - providers/*.yaml is no longer include_str!'d, and builtin_profiles() is gone from the openshell-providers API - the default provider_profile_sources is [{ type = "user" }], and a gateway with nothing imported reaches ready and serves an empty catalog — an empty catalog is a valid state, not a startup failure - the builtin source type is removed from the configuration schema, and a gateway.toml that still names it is rejected at parse time with the import command rather than an unknown-variant error - nothing reserves the canonical identifiers any more, so github, pypi, anthropic and the rest import at their own IDs and the imported profile is the only definition for that ID; the static_fallback that kept a shipped definition resident behind an imported one is gone with the source that produced it A collision between an interceptor-vended profile and an imported one still fails closed, which is the behavior that shadowing quietly bypassed for built-ins. Operators upgrading should export the profiles their deployment relies on before upgrading, or copy them from the providers/ directory of the matching release tag, then import them at the scope their providers use. Signed-off-by: Philippe Martin <phmartin@redhat.com> * docs(providers): document import-only provider profiles Rewrite the provider profile documentation around a catalog the operator builds rather than one the gateway ships. - gateway-config: the default is [{ type = "user" }], the builtin source type is gone and rejected at startup, and an empty catalog is a valid ready state - profiles: replace the built-in profile table and its shadowing semantics with the import workflow, and say plainly that a profile whose binary paths do not match the image is inert - manage-providers: replace the two fixed provider-type tables with `provider list-profiles`, and describe catalog-driven command inference - inference-routing: drop the "still loads built-in profiles for compatibility" transition text; its migration walkthrough is now the normal path - quickstart and the Docker Compose, GitHub, AWS, Google Cloud and Vertex tutorials: import the profile before creating the provider, since nothing resolves without it - release notes: a 0.1.0 migration section covering export-before-upgrade, importing from the release tag's providers/ directory, what happens to a provider whose profile is missing, and the removal of the legacy type aliases - README, architecture, the openshell-cli and debug-openshell-cluster skills, and the governance interceptor example follow the same change; the example's smoke assertion now imports a profile to prove an authoritative interceptor hides it Signed-off-by: Philippe Martin <phmartin@redhat.com> * fix(cli,e2e): distinguish catalog failures and authenticate OIDC seeding Addresses two findings from review (GATOR-c1bd9867-02 and -03). The provider profile catalog lookup collapsed its error into an empty catalog, so an authorization, availability or transport failure on ListProviderProfiles was indistinguishable from a gateway that genuinely has no profiles. Command inference then resolved nothing and the sandbox was created without the provider it needed, deferring the failure to the workload. Keep the lookup's outcome instead of discarding it. The credential warning is advisory and still degrades to its generic form, but inference now consults the catalog only when there is a command to resolve and surfaces the lookup failure when there is, naming the gateway and pointing at explicit --provider selection. Two regression tests cover it through a fake gateway whose ListProviderProfiles returns UNAVAILABLE while every other RPC succeeds: sandbox creation fails without sending a provider-less create request, and a sandbox with no trailing command still succeeds because it needs no catalog. The e2e profile seeding also ran unauthenticated in the OIDC lanes. Those lanes deliberately skip gateway registration and start the gateway without a TLS client CA, so no mTLS identity exists and no token has been acquired when the import runs; the wrapper exited during setup. Skipping the import is not sufficient because the provider tests now require the claude-code profile. Add e2e_register_oidc_admin_session, which mints an administrator token with Keycloak's password grant — the same grant the OIDC test helpers use — and writes the gateway metadata and token bundle that an interactive login would have stored, so the import runs as an authenticated administrator. The mTLS lanes keep the direct import unchanged. Both affected wrappers are covered: with-podman-gateway.sh had the same defect as with-docker-gateway.sh. Signed-off-by: Philippe Martin <phmartin@redhat.com> * refactor(cli)!: remove command-derived provider attachment Addresses GATOR-c1bd9867-01. A profile's `binaries` list authorizes a binary to reach that profile's endpoints. It is not a statement that running the binary asks for the provider, and reading it as attachment intent let a command silently gain provider authority: the aws-s3 example declares /bin/bash, so `sandbox create -- bash` resolved an existing aws-s3 provider and attached its credential-backed capability and network policy to the shell and its descendants. Attachment of an already-created provider never prompted, so the confirmation flow did not guard it. The distinction that would make inference sound — whether a declared binary is a profile's client or merely a permitted runtime — cannot be expressed: NetworkBinary carries only a path, and the field that encoded it was removed in 0.1.0. Any substitute is a guess. Restricting the guess to a unique claimant does not help, because uniqueness measures how sparse the catalog is rather than what the user intended, and a compiled list of "generic" commands could never cover an unbounded operator catalog. Remove trailing-command inference rather than approximate it. A provider is attached only when named with --provider, which still creates a missing provider from local discovery when the name matches an imported profile ID. Sandboxes with no providers remain a normal, fully supported state. Removing inference also settles GATOR-c1bd9867-02: with no consumer deriving authority from the catalog, its only remaining use is the advisory credential warning, so a failed lookup degrades that warning instead of blocking creation. The regression test now asserts that an unreachable catalog still creates the sandbox and attaches nothing. While repurposing the deduplication test, a pre-existing defect surfaced: repeating a name in --provider auto-created it twice and the second attempt failed with "provider already exists", because the explicit pass never consulted the set of names it had already handled. Guard it. Signed-off-by: Philippe Martin <phmartin@redhat.com> * fix(e2e): load the OIDC token and trust the gateway when seeding profiles Addresses the carried finding GATOR-c1bd9867-03. e2e_register_oidc_admin_session established a session the CLI never used. The CLI decides whether to load a stored bearer token by matching on the auth_mode field of the gateway metadata alone; the helper omitted that field, so the metadata fell through to the default arm and oidc_token.json stayed on disk unread. The profile import went out unauthenticated exactly as it had before the helper existed. The helper also installed no trust anchor, leaving the CLI unable to verify the gateway's self-signed serving certificate. Write auth_mode = "oidc" so the stored token is loaded, and install the CA at <gateway>/mtls/ca.crt. Only the CA is installed: with no client certificate or key on disk the CLI falls back to CA-only server verification and authenticates with the bearer token, which is what these lanes need because they start the gateway without --tls-client-ca. Certificate verification stays on; no insecure transport override is introduced. Assert the session before anything depends on it. ListProviderProfiles is annotated auth_mode: "bearer", so it cannot succeed unless the token was loaded and accepted. The helper now fails at that point, naming the gateway config directory and echoing the CLI output, rather than letting the defect surface later as an opaque profile import error. Both affected wrappers pass the PKI directory and CLI binary the helper needs; the mTLS lanes are untouched. Signed-off-by: Philippe Martin <phmartin@redhat.com> * fix(e2e): request the OpenShell scopes when minting the admin token The OIDC lanes failed at the session assertion added in b25dd0298 with PERMISSION_DENIED and "scope 'provider:read' required". Authentication was working -- the gateway logged ListProviderProfiles at gRPC status 7, which it can only reach once the bearer token has been loaded and accepted. The token simply carried no OpenShell scope. sandbox:*, provider:*, config:*, workspace:* and openshell:all are optional client scopes on the openshell-cli client in scripts/keycloak-realm.json, so Keycloak mints them only when the request asks for them. The password grant here asked for nothing, leaving the realm defaults (openid, profile, email, roles, web-origins, acr) and an access token that authorizes no RPC. Request "openid openshell:all", as e2e/python/oidc/oidc_auth_test.py already does for its administrator tokens. openshell:all is SCOPE_ALL in crates/openshell-server/src/auth/authz.rs, so one scope covers the setup calls without enumerating them. Verified against the realm: the token goes from "email profile openid" to "email profile openshell:all openid". Record the same scopes in metadata.json. The helper writes the bundle openshell gateway login would have stored, and oidc_scopes is the field that login path reads back, so leaving it out would misdescribe the stored token. Signed-off-by: Philippe Martin <phmartin@redhat.com> * fix(e2e): seed provider profiles once per VM lane gateway The VM lanes failed on the second test target with "custom provider profile 'anthropic' already exists" for all fifteen example profiles, and the import exited non-zero. e2e_import_example_provider_profiles was called from run_e2e_test, so it ran once per target -- four times against one long-lived gateway. That was harmless while import overwrote silently, but profiles are now import-only: ImportProviderProfiles is create-only and reports an existing id as an error-severity diagnostic, with no overwrite flag on the request. The first import therefore succeeds and every later one fails. Hoist the call to just after the conformance run, which is where the docker, podman and kube lanes already seed their catalogs. The profiles persist for the gateway's lifetime, so every target still finds them, and the E2E_TEST_OVERRIDE path is covered by the same single call. Signed-off-by: Philippe Martin <phmartin@redhat.com> * test(e2e): name the provider explicitly in the OIDC workspace-user test user_can_create_sandbox_with_inferred_provider_command reached the gateway once the admin session was fixed, and then failed: it asserted a missing-provider error, but the sandbox was created and died provisioning with "failed to spawn sandbox entrypoint process 'claude-code'". The test drove provider resolution by passing claude-code as the trailing command and relying on the CLI to infer the provider type from it. That inference is what this branch removed, so the trailing word is now nothing but an entrypoint, and the image has no such binary. The regression the test guards is not inference itself: it is that a workspace user resolving a provider is not gated behind Platform Admin. Name the provider with --provider, the only remaining way to attach one. The CLI still has to fetch the claude-code profile before it can auto-create the provider, so the lookup a workspace user must be allowed to make still happens, and auto-creation still stops at the non-interactive branch with "missing required provider". Both assertions therefore keep their meaning. Rename the test and rework its comments to describe what it now exercises; the old name would otherwise outlive the behavior it was named for. Signed-off-by: Philippe Martin <phmartin@redhat.com> * fix(providers): reconcile import-only profiles with main Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com> --------- Signed-off-by: Philippe Martin <phmartin@redhat.com> Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com> Co-authored-by: John Myers <9696606+johntmyers@users.noreply.github.com>
419 lines
16 KiB
Bash
Executable File
419 lines
16 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
|
|
# Run the Rust e2e smoke test against an openshell-gateway running the
|
|
# standalone VM compute driver (`openshell-driver-vm`).
|
|
#
|
|
# Architecture:
|
|
# * `openshell-sandbox` runs inside a NIC-less guest.
|
|
# * The host `openshell-supervisor` connects over virtio-vsock and owns
|
|
# gateway registration, policy evaluation, DNS, and external networking.
|
|
# * Readiness is authoritative on the gateway: a sandbox's phase
|
|
# flips to `Ready` the moment `ConnectSupervisor` registers, and
|
|
# back to `Provisioning` when the session drops. The VM driver
|
|
# only reports `Error` conditions for dead launcher processes.
|
|
#
|
|
# Usage:
|
|
# mise run e2e:vm
|
|
#
|
|
# What the script does:
|
|
# 1. When no prebuilt VM driver is supplied, ensures the VM runtime
|
|
# (libkrun) and bundled sandbox/supervisor binaries are staged.
|
|
# 2. Builds `openshell-gateway`, `openshell-driver-vm`, the native host
|
|
# `openshell-supervisor` host control, and the `openshell` CLI with the
|
|
# embedded runtime as needed. When CI supplies OPENSHELL_GATEWAY_BIN,
|
|
# OPENSHELL_VM_DRIVER_BIN, OPENSHELL_VM_SUPERVISOR_BIN, or OPENSHELL_BIN,
|
|
# the matching prebuilt binary is reused instead of rebuilt.
|
|
# 3. On macOS, codesigns the VM driver (libkrun needs the
|
|
# `com.apple.security.hypervisor` entitlement).
|
|
# 4. Writes a per-run gateway config with `[openshell.drivers.vm]`
|
|
# settings, starts the gateway with `--config <run-state>/gateway.toml`
|
|
# on a random free port, waits for an authenticated gateway status
|
|
# request to succeed, then runs the selected Rust e2e tests.
|
|
# 5. Tears the gateway down and (on failure) preserves the gateway
|
|
# log and every VM serial console log for post-mortem.
|
|
#
|
|
# Prerequisites (handled automatically by this script for local VM-driver builds):
|
|
# - `mise run vm:setup` — downloads / builds the libkrun runtime.
|
|
# - `mise run vm:supervisor` — builds the bundled sandbox supervisor.
|
|
|
|
set -euo pipefail
|
|
|
|
ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
source "${ROOT}/e2e/support/gateway-common.sh"
|
|
# shellcheck source=e2e/support/conformance.sh
|
|
source "${ROOT}/e2e/support/conformance.sh"
|
|
|
|
COMPRESSED_DIR="${ROOT}/target/vm-runtime-compressed"
|
|
GATEWAY_BIN="${OPENSHELL_GATEWAY_BIN:-${ROOT}/target/debug/openshell-gateway}"
|
|
DRIVER_BIN="${OPENSHELL_VM_DRIVER_BIN:-${ROOT}/target/debug/openshell-driver-vm}"
|
|
CLI_BIN="${OPENSHELL_BIN:-${ROOT}/target/debug/openshell}"
|
|
E2E_TEST_OVERRIDE="${OPENSHELL_E2E_VM_TEST:-}"
|
|
E2E_FEATURES="${OPENSHELL_E2E_VM_FEATURES-e2e-vm}"
|
|
SANDBOX_IMAGE="${OPENSHELL_SANDBOX_IMAGE:-${COMMUNITY_SANDBOX_IMAGE:-ghcr.io/nvidia/openshell-community/sandboxes/base:latest}}"
|
|
|
|
# The VM driver places `compute-driver.sock` under `[openshell.drivers.vm].state_dir`.
|
|
# AF_UNIX SUN_LEN is 104 bytes on macOS (108 on Linux), so paths anchored
|
|
# in the workspace's `target/` blow the limit on typical developer
|
|
# machines — e.g. a ~100-char `~/.superset/worktrees/.../target/...`
|
|
# prefix plus the `compute-driver.sock` leaf leaves no room. macOS'
|
|
# per-user `$TMPDIR` (`/var/folders/xx/.../T/`) can be 50+ chars too,
|
|
# so root state under `/tmp` unconditionally to keep UDS paths short.
|
|
STATE_DIR_ROOT="/tmp"
|
|
|
|
# Smoke test timeouts. First boot extracts the embedded libkrun runtime
|
|
# (~60-90MB of zstd per architecture) and prepares an ext4 root disk from the
|
|
# configured image. The guest then starts the sandbox supervisor directly; a cold
|
|
# microVM is typically ready within ~15s after image preparation.
|
|
GATEWAY_READY_TIMEOUT=60
|
|
SANDBOX_PROVISION_TIMEOUT=180
|
|
|
|
# ── Build prerequisites ──────────────────────────────────────────────
|
|
|
|
if [ -n "${RUSTC_WRAPPER:-}" ] && [ "${OPENSHELL_E2E_VM_ALLOW_RUSTC_WRAPPER:-0}" != "1" ]; then
|
|
echo "==> Building without RUSTC_WRAPPER=${RUSTC_WRAPPER} (set OPENSHELL_E2E_VM_ALLOW_RUSTC_WRAPPER=1 to keep it)"
|
|
unset RUSTC_WRAPPER
|
|
fi
|
|
|
|
if [ -z "${OPENSHELL_VM_DRIVER_BIN:-}" ]; then
|
|
mkdir -p "${COMPRESSED_DIR}"
|
|
|
|
if ! find "${COMPRESSED_DIR}" -maxdepth 1 -name 'libkrun*.zst' | grep -q .; then
|
|
echo "==> Preparing embedded VM runtime (mise run vm:setup)"
|
|
mise run vm:setup
|
|
fi
|
|
|
|
# Always rebuild the guest bundle so an e2e run cannot silently exercise a
|
|
# stale boundary binary after supervisor or isolation-interface changes.
|
|
echo "==> Building bundled VM supervisor (mise run vm:supervisor)"
|
|
mise run vm:supervisor
|
|
|
|
export OPENSHELL_VM_RUNTIME_COMPRESSED_DIR="${OPENSHELL_VM_RUNTIME_COMPRESSED_DIR:-${COMPRESSED_DIR}}"
|
|
else
|
|
echo "==> Skipping embedded VM runtime prep; prebuilt VM driver was supplied"
|
|
fi
|
|
|
|
build_packages=()
|
|
if [ -z "${OPENSHELL_GATEWAY_BIN:-}" ]; then
|
|
if [ "${OPENSHELL_E2E_EXTERNAL_COMPUTE_DRIVER:-0}" = "1" ]; then
|
|
echo "==> Building driver-free openshell-gateway"
|
|
cargo build \
|
|
-p openshell-gateway --bin openshell-gateway \
|
|
--no-default-features --features telemetry
|
|
else
|
|
build_packages+=(-p openshell-gateway)
|
|
fi
|
|
else
|
|
echo "==> Using prebuilt openshell-gateway at ${GATEWAY_BIN}"
|
|
fi
|
|
if [ -z "${OPENSHELL_VM_DRIVER_BIN:-}" ]; then
|
|
build_packages+=(-p openshell-driver-vm)
|
|
else
|
|
echo "==> Using prebuilt openshell-driver-vm at ${DRIVER_BIN}"
|
|
fi
|
|
if [ -z "${OPENSHELL_VM_SUPERVISOR_BIN:-}" ]; then
|
|
# The VM driver prefers a native sibling `openshell-supervisor`. Build it
|
|
# explicitly so a stale target/debug binary cannot disagree with the
|
|
# freshly embedded guest sandbox protocol.
|
|
build_packages+=(-p openshell-supervisor)
|
|
else
|
|
echo "==> Using prebuilt VM host supervisor at ${OPENSHELL_VM_SUPERVISOR_BIN}"
|
|
fi
|
|
if [ -z "${OPENSHELL_BIN:-}" ]; then
|
|
build_packages+=(-p openshell-cli)
|
|
else
|
|
echo "==> Using prebuilt openshell CLI at ${CLI_BIN}"
|
|
fi
|
|
|
|
if [ "${#build_packages[@]}" -gt 0 ]; then
|
|
echo "==> Building ${build_packages[*]}"
|
|
cargo build "${build_packages[@]}"
|
|
fi
|
|
|
|
for pair in \
|
|
"openshell-gateway:${GATEWAY_BIN}" \
|
|
"openshell-driver-vm:${DRIVER_BIN}" \
|
|
"openshell CLI:${CLI_BIN}"; do
|
|
label="${pair%%:*}"
|
|
path="${pair#*:}"
|
|
if [ ! -x "${path}" ]; then
|
|
echo "ERROR: expected ${label} binary at ${path}" >&2
|
|
exit 1
|
|
fi
|
|
done
|
|
export OPENSHELL_BIN="${CLI_BIN}"
|
|
DRIVER_DIR="$(dirname "${DRIVER_BIN}")"
|
|
|
|
if [ "$(uname -s)" = "Darwin" ]; then
|
|
echo "==> Codesigning openshell-driver-vm (Hypervisor entitlement)"
|
|
codesign \
|
|
--entitlements "${ROOT}/crates/openshell-driver-vm/entitlements.plist" \
|
|
--force \
|
|
-s - \
|
|
"${DRIVER_BIN}"
|
|
fi
|
|
|
|
# ── Pick a random free host port for the gateway ─────────────────────
|
|
|
|
HOST_PORT="$(python3 -c 'import socket
|
|
s = socket.socket()
|
|
s.bind(("", 0))
|
|
print(s.getsockname()[1])
|
|
s.close()')"
|
|
|
|
# Per-run state dir so concurrent e2e runs don't collide on the UDS or
|
|
# sandbox state. The VM driver creates `<state_dir>/compute-driver.sock`
|
|
# and `<state_dir>/sandboxes/<id>/overlay.ext4` under here. Keep the
|
|
# basename short — see the SUN_LEN comment above.
|
|
RUN_STATE_DIR="${STATE_DIR_ROOT}/os-vm-e2e-${HOST_PORT}-$$"
|
|
mkdir -p "${RUN_STATE_DIR}"
|
|
export XDG_CONFIG_HOME="${RUN_STATE_DIR}/config"
|
|
export XDG_DATA_HOME="${RUN_STATE_DIR}/data"
|
|
|
|
GATEWAY_LOG="$(mktemp /tmp/openshell-gateway-e2e.XXXXXX)"
|
|
GATEWAY_PID_FILE="${RUN_STATE_DIR}/gateway.pid"
|
|
GATEWAY_ARGS_FILE="${RUN_STATE_DIR}/gateway.args"
|
|
GATEWAY_CONFIG="${RUN_STATE_DIR}/gateway.toml"
|
|
GATEWAY_DB="${RUN_STATE_DIR}/gateway.db"
|
|
JWT_DIR="${RUN_STATE_DIR}/jwt"
|
|
PKI_DIR="${RUN_STATE_DIR}/pki"
|
|
GATEWAY_NAME="openshell-e2e-vm-${HOST_PORT}"
|
|
DRIVER_PID=""
|
|
DRIVER_LOG="${RUN_STATE_DIR}/vm-driver.log"
|
|
DRIVER_SOCKET="${RUN_STATE_DIR}/compute-driver.sock"
|
|
|
|
# ── Cleanup (trap) ───────────────────────────────────────────────────
|
|
|
|
cleanup() {
|
|
local exit_code=$?
|
|
|
|
local gateway_pid="${GATEWAY_PID:-}"
|
|
if [ -f "${GATEWAY_PID_FILE:-}" ]; then
|
|
gateway_pid="$(cat "${GATEWAY_PID_FILE}" 2>/dev/null || true)"
|
|
fi
|
|
|
|
if [ -n "${gateway_pid}" ] && kill -0 "${gateway_pid}" 2>/dev/null; then
|
|
echo "Stopping openshell-gateway (pid ${gateway_pid})..."
|
|
# SIGTERM first; gateway drops ManagedDriverProcess which SIGKILLs
|
|
# the driver and removes the UDS. Wait briefly, then force-kill.
|
|
kill -TERM "${gateway_pid}" 2>/dev/null || true
|
|
for _ in 1 2 3 4 5 6 7 8 9 10; do
|
|
kill -0 "${gateway_pid}" 2>/dev/null || break
|
|
sleep 0.5
|
|
done
|
|
kill -KILL "${gateway_pid}" 2>/dev/null || true
|
|
wait "${gateway_pid}" 2>/dev/null || true
|
|
fi
|
|
e2e_stop_process "${DRIVER_PID}" "external VM compute driver"
|
|
|
|
# On failure, keep the VM console log for debugging. We deliberately
|
|
# print it instead of leaving it on disk because the state dir gets
|
|
# wiped on success.
|
|
if [ "${exit_code}" -ne 0 ]; then
|
|
echo "=== gateway log (preserved for debugging) ==="
|
|
cat "${GATEWAY_LOG}" 2>/dev/null || true
|
|
echo "=== end gateway log ==="
|
|
if [ -f "${DRIVER_LOG}" ]; then
|
|
echo "=== external VM compute driver log ==="
|
|
cat "${DRIVER_LOG}" 2>/dev/null || true
|
|
echo "=== end external VM compute driver log ==="
|
|
fi
|
|
|
|
local console
|
|
while IFS= read -r -d '' console; do
|
|
echo "=== VM console log: ${console} ==="
|
|
cat "${console}" 2>/dev/null || true
|
|
echo "=== end VM console log ==="
|
|
done < <(find "${RUN_STATE_DIR}/sandboxes" -name 'rootfs-console.log' -print0 2>/dev/null)
|
|
fi
|
|
|
|
rm -f "${GATEWAY_LOG}" 2>/dev/null || true
|
|
# Only wipe the per-run state dir on success. On failure, leave it for
|
|
# post-mortem (serial console logs and root disk images).
|
|
if [ "${exit_code}" -eq 0 ]; then
|
|
rm -rf "${RUN_STATE_DIR}" 2>/dev/null || true
|
|
else
|
|
echo "NOTE: preserving ${RUN_STATE_DIR} for debugging"
|
|
fi
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
# ── Launch the gateway + VM driver ───────────────────────────────────
|
|
|
|
echo "==> Starting openshell-gateway on 127.0.0.1:${HOST_PORT} (state: ${RUN_STATE_DIR})"
|
|
|
|
# Pin `driver_dir` to the workspace `target/debug/` so we always pick up
|
|
# the driver we just cargo-built. Without this, the gateway's
|
|
# `resolve_compute_driver_bin` fallback prefers
|
|
# `~/.local/libexec/openshell/openshell-driver-vm` when present,
|
|
# which silently shadows development builds — a subtle source of
|
|
# stale-binary bugs in e2e runs.
|
|
# `grpc_endpoint` is consumed by the host supervisor. The host alias is
|
|
# normalized to loopback while keeping package-managed certificate naming.
|
|
e2e_generate_gateway_jwt "${JWT_DIR}"
|
|
e2e_generate_pki "${GATEWAY_BIN}" "${PKI_DIR}"
|
|
|
|
cat >"${GATEWAY_CONFIG}" <<EOF
|
|
[openshell]
|
|
version = 2
|
|
|
|
[openshell.gateway]
|
|
bind_address = "127.0.0.1:${HOST_PORT}"
|
|
compute_driver = "vm"
|
|
guest_tls_ca = "${PKI_DIR}/ca.crt"
|
|
guest_tls_cert = "${PKI_DIR}/client/tls.crt"
|
|
guest_tls_key = "${PKI_DIR}/client/tls.key"
|
|
|
|
[openshell.gateway.tls]
|
|
cert_path = "${PKI_DIR}/server/tls.crt"
|
|
key_path = "${PKI_DIR}/server/tls.key"
|
|
client_ca_path = "${PKI_DIR}/ca.crt"
|
|
|
|
[openshell.gateway.mtls_auth]
|
|
enabled = true
|
|
|
|
[openshell.gateway.gateway_jwt]
|
|
signing_key_path = "${JWT_DIR}/signing.pem"
|
|
public_key_path = "${JWT_DIR}/public.pem"
|
|
kid_path = "${JWT_DIR}/kid"
|
|
gateway_id = "${GATEWAY_NAME}"
|
|
# Local VM e2e gateways exercise the single-player default: sandbox JWTs
|
|
# identify the supervisor and do not expire.
|
|
|
|
[openshell.drivers.vm]
|
|
EOF
|
|
if [ "${OPENSHELL_E2E_EXTERNAL_COMPUTE_DRIVER:-0}" = "1" ]; then
|
|
printf 'socket_path = "%s"\n' "${DRIVER_SOCKET}" >>"${GATEWAY_CONFIG}"
|
|
else
|
|
cat >>"${GATEWAY_CONFIG}" <<EOF
|
|
grpc_endpoint = "https://host.openshell.internal:${HOST_PORT}"
|
|
driver_dir = "${DRIVER_DIR}"
|
|
state_dir = "${RUN_STATE_DIR}"
|
|
EOF
|
|
fi
|
|
|
|
if [ "${OPENSHELL_E2E_EXTERNAL_COMPUTE_DRIVER:-0}" = "1" ]; then
|
|
"${DRIVER_BIN}" \
|
|
--bind-socket "${DRIVER_SOCKET}" \
|
|
--allow-same-uid-peer \
|
|
--grpc-endpoint "https://host.openshell.internal:${HOST_PORT}" \
|
|
--default-image "${SANDBOX_IMAGE}" \
|
|
--state-dir "${RUN_STATE_DIR}" \
|
|
--guest-tls-ca "${PKI_DIR}/ca.crt" \
|
|
--guest-tls-cert "${PKI_DIR}/client/tls.crt" \
|
|
--guest-tls-key "${PKI_DIR}/client/tls.key" \
|
|
>"${DRIVER_LOG}" 2>&1 &
|
|
DRIVER_PID=$!
|
|
e2e_wait_for_socket \
|
|
"${DRIVER_SOCKET}" "${DRIVER_PID}" "external VM compute driver" 60
|
|
fi
|
|
|
|
GATEWAY_ARGS=(
|
|
--config "${GATEWAY_CONFIG}"
|
|
--db-url "sqlite:${GATEWAY_DB}?mode=rwc"
|
|
)
|
|
e2e_write_gateway_args_file "${GATEWAY_ARGS_FILE}" "${GATEWAY_ARGS[@]}"
|
|
|
|
"${GATEWAY_BIN}" "${GATEWAY_ARGS[@]}" \
|
|
>"${GATEWAY_LOG}" 2>&1 &
|
|
GATEWAY_PID=$!
|
|
printf '%s\n' "${GATEWAY_PID}" >"${GATEWAY_PID_FILE}"
|
|
|
|
# Register the gateway before polling so readiness exercises the same mTLS
|
|
# client path as the smoke tests.
|
|
CLI_GATEWAY_ENDPOINT="https://127.0.0.1:${HOST_PORT}"
|
|
e2e_register_mtls_gateway \
|
|
"${XDG_CONFIG_HOME}" \
|
|
"${GATEWAY_NAME}" \
|
|
"${CLI_GATEWAY_ENDPOINT}" \
|
|
"${HOST_PORT}" \
|
|
"${PKI_DIR}"
|
|
export OPENSHELL_GATEWAY_ENDPOINT="${CLI_GATEWAY_ENDPOINT}"
|
|
|
|
# ── Wait for gateway readiness ───────────────────────────────────────
|
|
#
|
|
# Poll the authenticated gRPC health path instead of coupling readiness to a
|
|
# particular gateway log message. The VM driver is spawned eagerly, while
|
|
# sandboxes are created on demand.
|
|
|
|
echo "==> Waiting for gateway readiness (timeout ${GATEWAY_READY_TIMEOUT}s)"
|
|
elapsed=0
|
|
last_status_output=""
|
|
while [ "${elapsed}" -lt "${GATEWAY_READY_TIMEOUT}" ]; do
|
|
if ! kill -0 "${GATEWAY_PID}" 2>/dev/null; then
|
|
echo "ERROR: openshell-gateway exited before becoming ready"
|
|
exit 1
|
|
fi
|
|
if last_status_output="$("${CLI_BIN}" status --output json 2>&1)" &&
|
|
printf '%s\n' "${last_status_output}" |
|
|
grep -Eq '"status"[[:space:]]*:[[:space:]]*"connected"'; then
|
|
echo "==> Gateway ready after ${elapsed}s"
|
|
break
|
|
fi
|
|
sleep 2
|
|
elapsed=$((elapsed + 2))
|
|
done
|
|
|
|
if [ "${elapsed}" -ge "${GATEWAY_READY_TIMEOUT}" ]; then
|
|
echo "ERROR: openshell-gateway did not become ready after ${GATEWAY_READY_TIMEOUT}s"
|
|
echo "=== last openshell status output ==="
|
|
if [ -n "${last_status_output}" ]; then
|
|
printf '%s\n' "${last_status_output}"
|
|
else
|
|
echo "<no output>"
|
|
fi
|
|
echo "=== end openshell status output ==="
|
|
exit 1
|
|
fi
|
|
|
|
# ── Run the smoke test ───────────────────────────────────────────────
|
|
#
|
|
# The CLI uses the raw endpoint but still resolves matching metadata so it
|
|
# can find the mTLS client bundle.
|
|
|
|
export OPENSHELL_E2E_DRIVER="vm"
|
|
export OPENSHELL_E2E_VM_STATE_DIR="${RUN_STATE_DIR}"
|
|
e2e_export_gateway_restart_metadata \
|
|
"${GATEWAY_BIN}" \
|
|
"${GATEWAY_ARGS_FILE}" \
|
|
"${GATEWAY_LOG}" \
|
|
"${GATEWAY_PID_FILE}"
|
|
|
|
# The VM driver creates each sandbox VM from a cached read-only ext4 root disk
|
|
# plus a writable overlay disk. The guest's sandbox supervisor then initializes
|
|
# policy, netns, Landlock, and sshd. On a cold host this is ~15s after image
|
|
# preparation; allow 180s for slower CI runners.
|
|
export OPENSHELL_PROVISION_TIMEOUT="${SANDBOX_PROVISION_TIMEOUT}"
|
|
|
|
e2e_run_openshell_conformance "VM"
|
|
|
|
# Seed the catalog once for the whole lane. The profiles live in the gateway
|
|
# for as long as it runs, and the import is create-only: a second import of
|
|
# the same directory fails with "custom provider profile '<id>' already
|
|
# exists", so this cannot move inside the per-target helper below.
|
|
e2e_import_example_provider_profiles "${CLI_BIN}" "${ROOT}" || exit 1
|
|
|
|
run_e2e_test() {
|
|
local test_target="$1"
|
|
shift
|
|
|
|
echo "==> Running e2e ${test_target} test (features: ${E2E_FEATURES}, endpoint: ${OPENSHELL_GATEWAY_ENDPOINT})"
|
|
cargo test \
|
|
--manifest-path "${ROOT}/e2e/rust/Cargo.toml" \
|
|
--features "${E2E_FEATURES}" \
|
|
--test "${test_target}" \
|
|
"$@" \
|
|
-- --nocapture
|
|
echo "==> ${test_target} test passed."
|
|
}
|
|
|
|
if [ -n "${E2E_TEST_OVERRIDE}" ]; then
|
|
run_e2e_test "${E2E_TEST_OVERRIDE}"
|
|
else
|
|
run_e2e_test host_gateway_alias
|
|
run_e2e_test vm_overlay
|
|
run_e2e_test vm_gateway_start
|
|
run_e2e_test vm_corporate_proxy
|
|
fi
|