mirror of
https://github.com/NVIDIA/OpenShell.git
synced 2026-10-15 05:09:44 +08:00
* feat(workspace): implement workspace model (Phase 1 of RFC 0011) Implements workspace and membership model providing hard isolation boundaries for multi-player OpenShell deployments. Workspace CRUD with Kubernetes-style Terminating phase for graceful deletion. All resources scoped by workspace via ObjectMeta. Membership RPCs for workspace access control. Persistence migration shifts name uniqueness to (object_type, workspace, name). Provider profiles support platform and workspace scoping. Service routing uses workspace-prefixed DNS labels. Inference routes renamed and workspace-scoped with DeleteInferenceRoute RPC. Python SDK with WorkspaceClient, two-method list pattern (workspace-scoped and for_all_workspaces), and workspace parameter on all methods. CLI workspace flags, TUI workspace cycling. K8s driver filters unmanaged CRs and uses delete preconditions. Podman driver uses immutable container IDs. Label serialization fixed across all put_if call sites. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(cli): delegate sandbox upload command to existing upload function The standalone `sandbox upload` command reimplemented upload logic inline with two bugs: it used `Path::exists()` which follows symlinks (rejecting dangling symlinks), and it ran git-aware filtering on symlink sources. The `run::sandbox_upload()` function already handles both cases correctly via `sandbox_upload_plan()`. Replace the inline logic with a call to the existing function. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(e2e): shorten sandbox names and fix test compatibility Shorten the sandbox name in initial_sparse_policy_is_acknowledged_as_loaded from 'e2e-2159-sparse-enrich' (22 chars) to 'e2e-sparse-enrich' (17 chars) to comply with MAX_ROUTABLE_NAME_LEN (19 chars). Also capture stderr in create_keep_with_args so future sandbox creation failures include the actual CLI error instead of reporting empty output. Signed-off-by: Derek Carr <decarr@redhat.com> * test(workspace): add test coverage for workspace CRUD and persistence isolation Add unit tests for workspace create happy path, get round-trip, get not-found, get empty-name rejection, already-exists error, and resolve_workspace not-found. Add persistence test proving cross-workspace name uniqueness (same name in different workspaces produces separate records). Add workspace name max-length boundary tests. Fix e2e harness to include stderr in name-parse-failure error path. Align Python e2e test_workspace_crud with try/finally pattern. Document provider profile catalog workspace scoping gap in RFC 0011. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(examples): update examples for workspace model compatibility Shorten sandbox names in demo scripts to fit the 19-character MAX_ROUTABLE_NAME_LEN limit: policy-demo prefix to pd-, multi-agent notepad derives a short SANDBOX_TAG from the run ID, governance interceptor uses gs-PID-RANDOM. Update vscode-remote-sandbox.md SSH host aliases from openshell-{name} to openshell-{name}.{workspace} format. Signed-off-by: Derek Carr <decarr@redhat.com> * feat(sdk): add workspace-scoped client and workspace CRUD Add WorkspaceScopedClient modeled after kube::Api::namespaced — captures workspace once and injects it into every sandbox request. Add workspace CRUD methods (create, get, list, delete) and list_sandboxes_all_workspaces on OpenShellClient. Extend SandboxRef with workspace field and add WorkspaceRef type. Include mock tests for all new operations. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(lint): resolve clippy warnings in workspace test assertions Signed-off-by: Derek Carr <decarr@redhat.com> * fix(docs): convert indented code blocks to fenced in RFC 0011 Signed-off-by: Derek Carr <decarr@redhat.com> * fix(lint): resolve clippy warnings and apply cargo fmt across workspace Auto-format with cargo fmt and fix clippy warnings exposed by the reformat: unnecessary qualifications, map_unwrap_or, identical match arms, unused variable prefix, dead code annotations, and let-unit-value in e2e harness. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(workspace): address workspace scoping issues from review - Add workspace field to settings JSON output (CLI) - Skip Podman containers missing workspace label instead of defaulting to empty string, matching K8s driver behavior - Add resource_version to list_by_scope SELECT in both SQLite and Postgres backends, with regression test - Gate PolicyLocalContext proposal/lookup routes on workspace readiness, returning 503 when workspace is not yet discovered - Block sandbox and provider creation in TUI all-workspaces mode - Clear workspace vectors in TUI reset_sandbox_state Signed-off-by: Derek Carr <decarr@redhat.com> * fix(workspace): make provider profile catalog workspace-aware Thread workspace through snapshot_catalog so the EffectiveProviderProfileCatalog enforces workspace boundaries on both read and write paths. UserProviderProfileSource now loads platform-scoped profiles (workspace "") plus the target workspace's profiles, preventing cross-workspace duplicate profile ID collisions that previously caused global catalog failures. Update RFC 0011 to reflect catalog scoping is implemented in Phase 1 rather than deferred to future work. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(persistence): include workspace column in atomic policy revision INSERT put_policy_revision_atomic omitted the workspace column from the INSERT into the objects table in both SQLite and Postgres backends, causing atomically-written policy revisions to lose their workspace association. Add workspace field to AtomicPolicyRevisionWrite and thread it through both backend INSERT statements, matching the non-atomic put_policy_revision path which already included it. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(proxy): skip ancestor walk when socket owner is the entrypoint collect_ancestor_identities walked the entire process tree above the entrypoint when the connecting process was the entrypoint itself, SHA256-hashing every ancestor binary (IDE, shell, container runtime). On dev machines with large binaries in the ancestor chain this exceeded the 30-second test timeout. When start_pid == stop_pid there are no intermediate ancestors to verify, so return an empty list immediately. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(workspace): make provider profile catalog scope-aware Allow the same profile ID at platform and workspace scopes by introducing layered catalog entries where workspace profiles shadow platform profiles. Add source and scope fields to the ProviderProfile proto and CLI output. Migrate List/Get handlers to the catalog, fixing divergence with runtime profile resolution. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(e2e): align podman e2e labels with centralized driver constants The podman driver moved its container labels to the centralized openshell.ai/ prefix, but the e2e test harness and cleanup script still referenced the old openshell.sandbox-* keys, causing the local_driver_token_restart test to fail on container lookup. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(e2e): align python profile isolation test with scope-aware catalog Platform profiles are now visible in workspace listings as fallbacks per the layered catalog design. Update the assertion to match. Signed-off-by: Derek Carr <decarr@redhat.com> * fix(workspace): honor profile_workspace in runtime profile resolution Runtime profile lookups now consult provider.profile_workspace via get_type_profile_for_scope. Providers created with --global-profile (profile_workspace="") resolve to the platform profile even when a workspace profile shadows the same ID. All 6 runtime call sites updated; type-only call sites remain scope-agnostic. Signed-off-by: Derek Carr <decarr@redhat.com> --------- Signed-off-by: Derek Carr <decarr@redhat.com>
153 lines
5.1 KiB
Protocol Buffer
153 lines
5.1 KiB
Protocol Buffer
// SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
syntax = "proto3";
|
|
|
|
package openshell.inference.v1;
|
|
|
|
import "datamodel.proto";
|
|
import "options.proto";
|
|
|
|
// Inference service provides workspace-scoped inference route configuration and bundle delivery.
|
|
service Inference {
|
|
// Return the resolved inference route bundle for sandbox-local execution.
|
|
rpc GetInferenceBundle(GetInferenceBundleRequest)
|
|
returns (GetInferenceBundleResponse);
|
|
|
|
// Set the inference route for a workspace.
|
|
//
|
|
// This controls how requests sent to `inference.local` are routed
|
|
// for sandboxes in the specified workspace.
|
|
rpc SetInferenceRoute(SetInferenceRouteRequest)
|
|
returns (SetInferenceRouteResponse);
|
|
|
|
// Get the inference route for a workspace.
|
|
rpc GetInferenceRoute(GetInferenceRouteRequest)
|
|
returns (GetInferenceRouteResponse);
|
|
|
|
// Delete an inference route from a workspace.
|
|
rpc DeleteInferenceRoute(DeleteInferenceRouteRequest)
|
|
returns (DeleteInferenceRouteResponse);
|
|
|
|
}
|
|
|
|
// Persisted inference route configuration.
|
|
//
|
|
// Only `provider_name` and `model_id` are stored; endpoint, protocols,
|
|
// credentials, and auth style are resolved from the provider at bundle time.
|
|
message InferenceRouteConfig {
|
|
// Provider record name backing this route.
|
|
string provider_name = 1;
|
|
// Model identifier to force on generation calls.
|
|
string model_id = 2;
|
|
// Per-route request timeout in seconds. 0 means use default (60s).
|
|
uint64 timeout_secs = 3;
|
|
}
|
|
|
|
// Storage envelope for a workspace-scoped inference route.
|
|
message InferenceRoute {
|
|
openshell.datamodel.v1.ObjectMeta metadata = 1;
|
|
InferenceRouteConfig config = 2;
|
|
// Monotonic version incremented on every update.
|
|
uint64 version = 3;
|
|
}
|
|
|
|
message SetInferenceRouteRequest {
|
|
// Provider record name to use for credentials + endpoint mapping.
|
|
string provider_name = 1;
|
|
// Model identifier to force on generation calls.
|
|
string model_id = 2;
|
|
// Route name to target. Empty string defaults to "inference.local" (user-facing).
|
|
// Use "sandbox-system" for the sandbox system-level inference route.
|
|
string route_name = 3;
|
|
// Verify the resolved upstream endpoint synchronously before persistence.
|
|
bool verify = 4;
|
|
// Skip synchronous endpoint validation before persistence.
|
|
bool no_verify = 5;
|
|
// Per-route request timeout in seconds. 0 means use default (60s).
|
|
uint64 timeout_secs = 6;
|
|
// Target workspace. Empty string defaults to "default".
|
|
string workspace = 7;
|
|
}
|
|
|
|
message ValidatedEndpoint {
|
|
string url = 1;
|
|
string protocol = 2;
|
|
}
|
|
|
|
message SetInferenceRouteResponse {
|
|
string provider_name = 1;
|
|
string model_id = 2;
|
|
uint64 version = 3;
|
|
// Route name that was configured.
|
|
string route_name = 4;
|
|
// Whether endpoint verification ran as part of this request.
|
|
bool validation_performed = 5;
|
|
// The concrete endpoints that were probed during validation, when available.
|
|
repeated ValidatedEndpoint validated_endpoints = 6;
|
|
// Per-route request timeout in seconds that was persisted.
|
|
uint64 timeout_secs = 7;
|
|
// Workspace the route was configured in.
|
|
string workspace = 8;
|
|
}
|
|
|
|
message GetInferenceRouteRequest {
|
|
// Route name to query. Empty string defaults to "inference.local" (user-facing).
|
|
// Use "sandbox-system" for the sandbox system-level inference route.
|
|
string route_name = 1;
|
|
// Target workspace. Empty string defaults to "default".
|
|
string workspace = 2;
|
|
}
|
|
|
|
message GetInferenceRouteResponse {
|
|
string provider_name = 1;
|
|
string model_id = 2;
|
|
uint64 version = 3;
|
|
// Route name that was queried.
|
|
string route_name = 4;
|
|
// Per-route request timeout in seconds. 0 means default (60s).
|
|
uint64 timeout_secs = 5;
|
|
// Workspace the route belongs to.
|
|
string workspace = 6;
|
|
}
|
|
|
|
message DeleteInferenceRouteRequest {
|
|
// Route name to delete. Empty string defaults to "inference.local" (user-facing).
|
|
// Use "sandbox-system" for the sandbox system-level inference route.
|
|
string route_name = 1;
|
|
// Target workspace. Empty string defaults to "default".
|
|
string workspace = 2;
|
|
}
|
|
|
|
message DeleteInferenceRouteResponse {
|
|
// Whether a route was actually deleted.
|
|
bool deleted = 1;
|
|
}
|
|
|
|
message GetInferenceBundleRequest {}
|
|
|
|
// A single resolved route ready for sandbox-local execution.
|
|
message ResolvedRoute {
|
|
string name = 1;
|
|
string base_url = 2;
|
|
repeated string protocols = 3;
|
|
string api_key = 4 [(openshell.options.v1.secret) = true];
|
|
string model_id = 5;
|
|
string provider_type = 6;
|
|
// Per-route request timeout in seconds. 0 means use default (60s).
|
|
uint64 timeout_secs = 7;
|
|
// When true, the model identifier is embedded in the URL path (e.g. Vertex AI).
|
|
bool model_in_path = 8;
|
|
// Optional override for the request path. When set, replaces the protocol-derived path.
|
|
// An empty string means POST directly to base_url/model_id with no additional path.
|
|
optional string request_path_override = 9;
|
|
}
|
|
|
|
message GetInferenceBundleResponse {
|
|
repeated ResolvedRoute routes = 1;
|
|
// Opaque revision tag for cache freshness checks.
|
|
string revision = 2;
|
|
// Timestamp (epoch ms) when this bundle was generated.
|
|
int64 generated_at_ms = 3;
|
|
}
|