mirror of
https://github.com/NVIDIA/OpenShell.git
synced 2026-10-20 06:00:06 +08:00
Adam Miller
436c59a2a1
* fix(rpm): restore 0.0.0.0 bind address for Podman via default gateway.toml The gateway binary default changed to 127.0.0.1 in recent commits (b61a98db,f257ed01). This breaks the Podman compute driver because sandbox containers reach the gateway over the host network bridge and cannot connect to the loopback address. Ship a default TOML config template that the RPM systemd unit seeds into ~/.config/openshell/gateway.toml on first start. The template sets bind_address = "0.0.0.0:17670" and pins compute_drivers = ["podman"] to prevent unexpected driver selection when Docker is also installed. The binary default remains 127.0.0.1 (secure-by-default for non-RPM installs). Changes: - deploy/rpm/gateway.toml.default: new default config template - openshell.spec: install template to %{_datadir}/openshell-gateway/; add ExecStartPre to seed ~/.config/openshell/gateway.toml on first start; add %check assertions for template presence and unit reference - deploy/rpm/CONFIGURATION.md: document default config, override paths, and updated bind address throughout - deploy/rpm/QUICKSTART.md: update bind address note for RPM installs - crates/openshell-server/src/config_file.rs: contract test that parses the RPM template through load() and asserts bind_address=0.0.0.0 and compute_drivers=[podman] - e2e/with-podman-gateway.sh: start from RPM template as base config so e2e exercises the same TOML path RPM users get on first start * fix(rpm): restore openshell_python_version macro in dist-info metadata * fix(rpm): reset Packit-managed version fields to match main baseline Version, Source0, and Source1 were stamped to 0.0.43 by Packit CI during branch builds. Reset to 0.0.37 (current main baseline) so the spec diff only contains our intentional changes. Packit's fix-spec-file action will re-stamp these fields at build time. * Revert "fix(rpm): reset Packit-managed version fields to match main baseline" This reverts commit8ef9d7ad8e. * fix(rpm): introduce openshell_version macro; remove hardcoded versions Add %global openshell_version as the single source of truth for the package version. Version:, Source0:, Source1:, openshell_cargo_version, and openshell_python_version all expand from this one macro. Update .packit.yaml fix-spec-file to patch %global openshell_version instead of the Version:, Source0:, and Source1: lines individually.
31 lines
1.3 KiB
Plaintext
31 lines
1.3 KiB
Plaintext
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
#
|
|
# Default gateway configuration for RPM installs.
|
|
#
|
|
# This file is seeded to ~/.config/openshell/gateway.toml on first start
|
|
# of the openshell-gateway.service systemd user unit. Edit that copy to
|
|
# customize. This file is not read directly at runtime.
|
|
#
|
|
# Configuration precedence (highest to lowest):
|
|
# CLI flag > OPENSHELL_* env var > TOML file > built-in default
|
|
#
|
|
# To override settings without editing this file, set OPENSHELL_* variables
|
|
# in ~/.config/openshell/gateway.env or run:
|
|
# systemctl --user edit openshell-gateway
|
|
|
|
[openshell]
|
|
version = 1
|
|
|
|
[openshell.gateway]
|
|
# Podman sandbox containers reach the gateway over the host network bridge,
|
|
# which requires binding to all interfaces. Override to 127.0.0.1:17670 if
|
|
# you don't use Podman or want loopback-only access (e.g. behind a reverse
|
|
# proxy). mTLS is enabled by default and protects all connections.
|
|
bind_address = "0.0.0.0:17670"
|
|
|
|
# Pin to the Podman compute driver. Without this, the gateway auto-detects
|
|
# in order: Kubernetes, Podman, Docker. Pinning prevents unexpected driver
|
|
# selection if Docker is also installed on the host.
|
|
compute_drivers = ["podman"]
|