mirror of
https://github.com/TencentCloud/Octop.git
synced 2026-10-25 07:03:26 +08:00
jubaoliang
5b6c91302c
Allow experts and skill packages to carry composer defaults so that installed/created agents start with the author's chosen knowledge bases and MCP servers. Defaults are persisted as agent profile columns and validated against the installing user. Adds the per-user policy resource table (migration 014) and wires the dashboard composer fields plus locale strings. - Add knowledge_base_ids and mcp_servers to the agent profile schema - Validate KB/MCP ids on expert/skill-package install and create paths - Persist defaults via migrate.py helper and 014_user_policy migration - Surface composer default fields in the dashboard expert/skill UI
106 lines
3.4 KiB
Python
106 lines
3.4 KiB
Python
"""Unit tests for connector default_open config helpers."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from octop.infra.connectors.default_open import (
|
|
build_instance_config_json,
|
|
merge_mcp_servers_with_defaults,
|
|
read_default_open,
|
|
)
|
|
|
|
|
|
def test_read_default_open_defaults_false():
|
|
assert read_default_open(None) is False
|
|
assert read_default_open({}) is False
|
|
assert read_default_open({"default_open": False}) is False
|
|
assert read_default_open({"default_open": "yes"}) is False
|
|
|
|
|
|
def test_read_default_open_true():
|
|
assert read_default_open({"default_open": True}) is True
|
|
|
|
|
|
def test_build_instance_config_json_omits_when_false():
|
|
assert build_instance_config_json(kind="tencent-docs", default_open=False) is None
|
|
assert (
|
|
build_instance_config_json(
|
|
kind="qq-mail",
|
|
default_open=False,
|
|
email="a@qq.com",
|
|
)
|
|
== '{"email": "a@qq.com"}'
|
|
)
|
|
|
|
|
|
def test_build_instance_config_json_includes_when_true():
|
|
raw = build_instance_config_json(kind="tencent-docs", default_open=True)
|
|
assert raw == '{"default_open": true}'
|
|
raw_mail = build_instance_config_json(
|
|
kind="qq-mail",
|
|
default_open=True,
|
|
email="a@qq.com",
|
|
)
|
|
assert '"default_open": true' in raw_mail
|
|
assert '"email": "a@qq.com"' in raw_mail
|
|
|
|
|
|
def test_build_instance_config_json_includes_description():
|
|
raw = build_instance_config_json(
|
|
kind="tencent-docs",
|
|
description="团队文档连接",
|
|
)
|
|
assert raw == '{"description": "团队文档连接"}'
|
|
|
|
|
|
def test_merge_mcp_servers_with_defaults_unions_and_dedupes():
|
|
# Default: apply defaults only when explicit is None (IM-style).
|
|
assert merge_mcp_servers_with_defaults(None, ["a", "b"]) == ["a", "b"]
|
|
assert merge_mcp_servers_with_defaults(["b", "c"], ["a", "b"]) == ["b", "c"]
|
|
assert merge_mcp_servers_with_defaults(["x"], []) == ["x"]
|
|
assert merge_mcp_servers_with_defaults(None, []) is None
|
|
assert merge_mcp_servers_with_defaults([], []) is None
|
|
# Cron-style force union.
|
|
assert merge_mcp_servers_with_defaults(["b", "c"], ["a", "b"], apply_defaults=True) == [
|
|
"b",
|
|
"c",
|
|
"a",
|
|
]
|
|
|
|
|
|
def test_merge_respects_dashboard_opt_out():
|
|
# Explicit list (including empty) must not re-add defaults.
|
|
assert merge_mcp_servers_with_defaults(["b"], ["a"], apply_defaults=False) == ["b"]
|
|
|
|
|
|
def test_merge_turn_mcp_servers_unions_extra_defaults() -> None:
|
|
from octop.infra.connectors.service import ConnectorService
|
|
|
|
class _Svc:
|
|
def list_default_open_mcp_server_names(self, _uid: int) -> list[str]:
|
|
return ["always"]
|
|
|
|
def list_active_mcp_server_names(self, _uid: int) -> list[str]:
|
|
return ["always", "expert"]
|
|
|
|
svc = _Svc()
|
|
assert ConnectorService.merge_turn_mcp_servers(
|
|
svc, # type: ignore[arg-type]
|
|
1,
|
|
None,
|
|
extra_defaults=["expert", "always", "gone", ""],
|
|
) == ["always", "expert"]
|
|
assert (
|
|
ConnectorService.merge_turn_mcp_servers(
|
|
svc, # type: ignore[arg-type]
|
|
1,
|
|
[],
|
|
apply_defaults=False,
|
|
extra_defaults=["expert"],
|
|
)
|
|
is None
|
|
)
|
|
assert merge_mcp_servers_with_defaults([], ["a"], apply_defaults=False) is None
|
|
# IM / Cron force defaults.
|
|
assert merge_mcp_servers_with_defaults([], ["a"], apply_defaults=True) == ["a"]
|
|
assert merge_mcp_servers_with_defaults(None, ["a"], apply_defaults=True) == ["a"]
|