mirror of
https://github.com/NVIDIA/Model-Optimizer.git
synced 2026-10-20 05:59:32 +08:00
### What does this PR do? Type of change: New feature / infrastructure improvement Follow-up to #1285 for correct CI test environment for megatron based tests Replaces `tox` + `tox-current-env` with `nox` for all test, lint, docs, and wheel build sessions. The primary motivation was that `tox-current-env` is incompatible with uv venvs in NGC containers (e.g. NeMo's `/opt/venv`) — it picks the system Python via `sys._base_executable` instead of the container's venv Python which has megatron packages pre-installed. Key changes: - **`noxfile.py`** replaces `tox.ini` with GPU, CPU unit, partial-install, pre-commit, docs, and wheel sessions - **GPU sessions** use `venv_backend="none"` (run directly in container env) and `python -m pip/pytest` to avoid PATH mismatches - **uv** is set as the default venv backend (if available) for CPU sessions (faster installs) Also includes CI workflow simplifications: - **`_pr_gate.yml`** new reusable workflow centralizing file-change detection + linux-check wait logic (was duplicated across 3 workflow files) - **Collapsed pr/non-pr job pairs** into single jobs with conditional `runs-on` in `gpu_tests.yml`, `example_tests.yml`, `regression_tests.yml` - **Collapsed `multi-py` / `multi-torch` / `multi-transformers`** into a single `multi-version` matrix job in `unit_tests.yml` - **PR path filtering** for unit test secondary jobs (multi-version, launcher, partial-install) — skipped if no relevant files changed - **Fixed schedule/workflow_dispatch skipping** — jobs with `needs: [pr-gate]` were incorrectly skipped when all pr-gate internal jobs were skipped; fixed by making the gate job always run - **multi-version, launcher, partial-install** now also run on `schedule` / `workflow_dispatch` ### Usage ```bash python -m pip install nox uv # install nox and uv (once) nox -l # list all sessions nox -s gpu_megatron # run a GPU session (inside container) nox -s "unit-3.12(torch_211, tf_latest)" # run a specific unit test combination nox -s "unit-3.12(torch_211, tf_latest)" -R # force-recreate venv (e.g. after dep changes) COVERAGE_PROCESS_START=pyproject.toml nox -s "unit-3.12(torch_211, tf_latest)" # with coverage ``` ### Testing - Ran `nox -l` to verify all session names - Ran `gpu_megatron` session locally inside NeMo container — confirmed it uses `/opt/venv/bin/python` correctly - Manually triggered nightly-runs: - Unit: https://github.com/NVIDIA/Model-Optimizer/actions/runs/24608013657 - GPU: https://github.com/NVIDIA/Model-Optimizer/actions/runs/24608018763 - Examples: https://github.com/NVIDIA/Model-Optimizer/actions/runs/24608017322 ### Before your PR is "*Ready for review*" Make sure you read and follow [Contributor guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md) and your commits are signed (`git commit -s -S`). Make sure you read and follow the [Security Best Practices](https://github.com/NVIDIA/Model-Optimizer/blob/main/SECURITY.md#security-coding-practices-for-contributors) (e.g. avoiding hardcoded `trust_remote_code=True`, `torch.load(..., weights_only=False)`, `pickle`, etc.). - Is this change backward compatible?: N/A — CI infrastructure only - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: ✅ (added `nox` and `uv` to `dev-test`, both Apache-2.0) - Did you write any new necessary tests?: N/A - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A — no user-facing changes ### Additional Information Supersedes the tox-current-env workaround in the parent branch. --------- Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
196 lines
8.2 KiB
Python
196 lines
8.2 KiB
Python
# SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
"""Nox session definitions for testing, linting, docs, and wheel builds.
|
|
|
|
Usage:
|
|
python -m pip install nox uv # install nox and uv (once)
|
|
nox -l # list all sessions
|
|
nox -s gpu_megatron # run a GPU session (inside container)
|
|
nox -s "unit-3.12(torch_211, tf_latest)" # run a specific unit test combination
|
|
nox -s "unit-3.12(torch_211, tf_latest)" -R # force-recreate venv (e.g. after dep changes)
|
|
COVERAGE_PROCESS_START=pyproject.toml nox -s "unit-3.12(torch_211, tf_latest)" # with coverage
|
|
"""
|
|
|
|
import glob
|
|
import os
|
|
import shutil
|
|
|
|
import nox
|
|
|
|
nox.options.default_venv_backend = "uv" if shutil.which("uv") else "virtualenv"
|
|
nox.options.envdir = "/tmp/.nox"
|
|
nox.options.reuse_existing_virtualenvs = True
|
|
|
|
TORCH_VERSIONS = {
|
|
"torch_28": "torchvision~=0.23.0",
|
|
"torch_29": "torchvision~=0.24.0",
|
|
"torch_210": "torchvision~=0.25.0",
|
|
"torch_211": "torchvision~=0.26.0",
|
|
}
|
|
|
|
TRANSFORMERS_VERSIONS = {
|
|
"tf_latest": None,
|
|
"tf_min": "transformers~=4.56.0",
|
|
}
|
|
|
|
|
|
def _cov_args():
|
|
"""Return --cov when COVERAGE_PROCESS_START is set (CI only)."""
|
|
return ["--cov"] if os.environ.get("COVERAGE_PROCESS_START") else []
|
|
|
|
|
|
# ─── CPU unit tests ───────────────────────────────────────────────────────────
|
|
@nox.session(python=["3.10", "3.11", "3.12", "3.13"])
|
|
@nox.parametrize("tf_ver", [nox.param(k, id=k) for k in TRANSFORMERS_VERSIONS])
|
|
@nox.parametrize("torch_ver", [nox.param(k, id=k) for k in TORCH_VERSIONS])
|
|
def unit(session, torch_ver, tf_ver):
|
|
"""Unit tests — parametrized over torch and transformers versions."""
|
|
session.install(TORCH_VERSIONS[torch_ver], "-e", ".[all,dev-test]")
|
|
tf_pin = TRANSFORMERS_VERSIONS[tf_ver]
|
|
if tf_pin:
|
|
session.install(tf_pin)
|
|
session.run("python", "-m", "pytest", "tests/unit", *_cov_args())
|
|
|
|
|
|
@nox.session(python="3.12")
|
|
@nox.parametrize("subset", ["onnx", "torch", "torch_deploy"])
|
|
def partial_unit(session, subset):
|
|
"""Unit tests with partial installs."""
|
|
if subset == "onnx":
|
|
session.install("torchvision~=0.26.0", ".[onnx,dev-test]")
|
|
session.run("python", "-m", "pytest", "tests/unit/onnx")
|
|
elif subset == "torch":
|
|
session.install("megatron-core", ".[dev-test]")
|
|
session.run(
|
|
"python",
|
|
"-m",
|
|
"pytest",
|
|
"tests/unit/torch",
|
|
"--ignore=tests/unit/torch/deploy",
|
|
"--ignore=tests/unit/torch/puzzletron",
|
|
)
|
|
else: # torch_deploy
|
|
session.install(".[onnx,dev-test]")
|
|
session.run("python", "-m", "pytest", "tests/unit/torch/deploy")
|
|
|
|
|
|
# ─── GPU sessions (run inside containers — no new venv) ──────────────────────
|
|
# `venv_backend="none"` skips creating a new venv so the session runs directly in the container's
|
|
# existing Python environment (e.g. /opt/venv in NeMo) instead of an isolated one.
|
|
# Use `python -m pip/pytest` to ensure the container's active venv Python is used,
|
|
# not a stale PATH entry (e.g. NeMo container has pip → /usr/local/bin/pip but python → /opt/venv/bin/python).
|
|
# Container: nvcr.io/nvidia/pytorch:26.01-py3 or later
|
|
@nox.session(venv_backend="none")
|
|
def gpu(session):
|
|
# tests/gpu/_extensions/test_onnx_extensions.py fails for newer containers
|
|
# until https://github.com/tbenthompson/cppimport/pull/98
|
|
session.run(
|
|
"python",
|
|
"-m",
|
|
"pip",
|
|
"install",
|
|
"--no-build-isolation",
|
|
"git+https://github.com/Dao-AILab/fast-hadamard-transform.git",
|
|
)
|
|
session.run("python", "-m", "pip", "install", "-e", ".[all,dev-test]")
|
|
session.run("python", "-m", "pip", "uninstall", "-y", "cupy-cuda12x")
|
|
session.run("python", "-m", "pip", "install", "cupy-cuda13x")
|
|
session.run(
|
|
"python",
|
|
"-m",
|
|
"pip",
|
|
"install",
|
|
"--no-build-isolation",
|
|
"git+https://github.com/state-spaces/mamba.git",
|
|
"git+https://github.com/Dao-AILab/causal-conv1d.git",
|
|
)
|
|
session.run("python", "-m", "pytest", "tests/gpu", *_cov_args())
|
|
|
|
|
|
# Container: nvcr.io/nvidia/nemo:26.04 or later
|
|
@nox.session(venv_backend="none")
|
|
def gpu_megatron(session):
|
|
# nemo:26.04 has transformers 5.x but system-wide installed trtllm 1.2.0 which does not support it causing import errors
|
|
session.run("pip", "uninstall", "-y", "tensorrt_llm")
|
|
session.run("python", "-m", "pip", "install", "-e", ".[hf,dev-test]")
|
|
session.run("python", "-m", "pytest", "tests/gpu_megatron", *_cov_args())
|
|
|
|
|
|
# Container: nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc10 or later
|
|
@nox.session(venv_backend="none")
|
|
def gpu_trtllm(session):
|
|
session.run("python", "-m", "pip", "install", "-e", ".[hf,dev-test]")
|
|
session.run("python", "-m", "pytest", "tests/gpu_trtllm", *_cov_args())
|
|
|
|
|
|
# Container: nvcr.io/nvidia/pytorch:26.01-py3 or later
|
|
@nox.session(venv_backend="none")
|
|
def regression(session):
|
|
session.run("python", "-m", "pip", "install", "-e", ".[hf,dev-test]")
|
|
session.run("python", "-m", "pytest", "tests/regression", *_cov_args())
|
|
|
|
|
|
# ─── Code quality ─────────────────────────────────────────────────────────────
|
|
@nox.session
|
|
def pre_commit_all(session):
|
|
session.install("-e", ".[all,dev-lint]")
|
|
session.run("pre-commit", "run", "--all-files", "--show-diff-on-failure")
|
|
|
|
|
|
@nox.session
|
|
def pre_commit_diff(session):
|
|
session.install("-e", ".[all,dev-lint]")
|
|
session.run("pre-commit", "run", "--from-ref", "origin/main", "--to-ref", "HEAD")
|
|
|
|
|
|
# ─── Docs ─────────────────────────────────────────────────────────────────────
|
|
@nox.session
|
|
def docs(session):
|
|
session.install("-e", ".[all,dev-docs]")
|
|
shutil.rmtree("docs/build", ignore_errors=True)
|
|
shutil.rmtree("docs/source/reference/generated", ignore_errors=True)
|
|
with session.chdir("docs"):
|
|
session.run(
|
|
"sphinx-build",
|
|
"source",
|
|
"build/html",
|
|
"--fail-on-warning",
|
|
"--show-traceback",
|
|
"--keep-going",
|
|
)
|
|
|
|
|
|
@nox.session
|
|
def docs_debug(session):
|
|
session.install("-e", ".[all,dev-docs]")
|
|
shutil.rmtree("docs/build", ignore_errors=True)
|
|
shutil.rmtree("docs/source/reference/generated", ignore_errors=True)
|
|
with session.chdir("docs"):
|
|
session.run("sphinx-autobuild", "source", "build/html", "--host", "0.0.0.0")
|
|
|
|
|
|
# ─── Wheel build ──────────────────────────────────────────────────────────────
|
|
@nox.session
|
|
def build_wheel(session):
|
|
shutil.rmtree("build", ignore_errors=True)
|
|
session.install("twine")
|
|
session.run("pip", "wheel", "--no-deps", "--wheel-dir=dist", ".")
|
|
wheels = glob.glob("dist/*.whl")
|
|
session.run("twine", "check", *wheels)
|
|
(modelopt_wheel,) = glob.glob("dist/nvidia_modelopt-*.whl")
|
|
session.install(modelopt_wheel, "-f", "dist")
|
|
with session.chdir("dist"):
|
|
session.run("python", "-c", "import modelopt; print(modelopt.__version__)")
|