mirror of
https://github.com/NVIDIA/Model-Optimizer.git
synced 2026-10-30 07:34:44 +08:00
## What does this PR do? **Type of change:** Refactor <!-- Use one of the following: Bug fix, new feature, new example, new tests, documentation. --> **Overview:** Jira ticket: https://jirasw.nvidia.com/browse/OMNIML-2955 Main changes : - Consolidate Eagle data loading with @ChenhanYu 's implementation of `transformers_dataset.py` - Refactor: baked the following logics from `example/main.py` to `modelopt/torch` for cleaner example entrance: - default config selecting and merging with custom config - tokenizer post-processor (chat template and pad_tok_id) - d2t loading - Implementation refactor: In HF workflow, reuse base modfel's input hidden states as input_embedding, instead of calculating from input_ids. This has two main benefits: - Easier VLM support, which has various embedding processing logics. - Training effieicy. - Deprecating eagle1 from the example. It is still available by setting custom config. - Other minor fixes and readme updates. ## Usage <!-- You can potentially add a usage example below. --> ```python # Add a code snippet demonstrating how to use this ``` ## Testing <!-- Mention how have you tested your change if applicable. --> Tested that training curves after changes (both online&offline) is identical with original branch: <img width="1073" height="634" alt="image" src="https://github.com/user-attachments/assets/abfd7bea-c82c-48a7-8181-68c5a9e4da8d" /> ## Before your PR is "*Ready for review*" <!-- If you haven't finished some of the above items you can still open `Draft` PR. --> - **Make sure you read and follow [Contributor guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md)** and your commits are signed. - **Is this change backward compatible?**: Yes/No <!--- If No, explain why. --> - **Did you write any new necessary tests?**: Yes/No - **Did you add or update any necessary documentation?**: Yes/No - **Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?**: Yes/No <!--- Only for new features, API changes, critical bug fixes or bw breaking changes. --> ## Additional Information <!-- E.g. related issue. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **New Features** * Added draft vocabulary cache support for EAGLE model training, enabling runtime vocabulary customization via `--draft_vocab_cache` parameter * Introduced new data loading utilities with sharding, streaming, and tokenization support for large-scale training * Added optional `--log_steps` configuration to training launcher * **Documentation** * Updated EAGLE configuration guides with draft vocabulary cache setup instructions and examples * **Refactor** * Restructured data pipeline for offline training with improved dataset handling and batching * Updated command-line arguments across training scripts (`--input-data` replaces `--input-file`) <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
104 lines
3.8 KiB
Python
104 lines
3.8 KiB
Python
# SPDX-FileCopyrightText: Copyright (c) 2023-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import argparse
|
|
|
|
from accelerate import Accelerator
|
|
from datasets import load_dataset
|
|
from tqdm import tqdm
|
|
from transformers import AutoTokenizer
|
|
|
|
import modelopt.torch.opt as mto
|
|
from modelopt.torch.speculative.plugins.transformers import HFARValidation
|
|
from modelopt.torch.speculative.utils import load_vlm_or_llm_with_kwargs
|
|
|
|
mto.enable_huggingface_checkpointing()
|
|
|
|
|
|
def validate_ar(model, tokenizer, ds, steps=3, osl=20, num_samples=80, device=None):
|
|
validator = HFARValidation(model, tokenizer)
|
|
num_samples = min(num_samples, len(ds))
|
|
ars = []
|
|
for i in tqdm(range(num_samples), desc="Validating AR"):
|
|
prompt = ds[i]["prompt"][0]
|
|
input_ids = tokenizer(prompt, return_tensors="pt").input_ids
|
|
# Apply chat template to the prompt, continuing with assistant response
|
|
if hasattr(tokenizer, "apply_chat_template"):
|
|
chat_messages = [
|
|
{"role": "user", "content": prompt},
|
|
]
|
|
prompt = tokenizer.apply_chat_template(
|
|
chat_messages, tokenize=False, add_generation_prompt=True
|
|
)
|
|
input_ids = tokenizer(prompt, return_tensors="pt").input_ids
|
|
if device:
|
|
input_ids = input_ids.to(device)
|
|
|
|
# validate AR
|
|
_, ar = validator.validate(osl, input_ids=input_ids, steps=steps)
|
|
ars.append(ar)
|
|
return ars
|
|
|
|
|
|
def main():
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument("--model_path", type=str, required=True, help="Path to model directory")
|
|
parser.add_argument("--steps", type=int, default=3, help="Steps for AR validation")
|
|
parser.add_argument(
|
|
"--osl", type=int, default=32, help="Output sequence length for AR validation"
|
|
)
|
|
parser.add_argument(
|
|
"--num_samples", type=int, default=80, help="Number of MT-Bench samples to use"
|
|
)
|
|
parser.add_argument(
|
|
"--ar_lower_bound",
|
|
type=float,
|
|
default=None,
|
|
help="AR lower bound for validation. If provided, will throw error if AR is below threshold.",
|
|
)
|
|
args = parser.parse_args()
|
|
|
|
accelerator = Accelerator()
|
|
# Load model and tokenizer
|
|
_, model = load_vlm_or_llm_with_kwargs(args.model_path, device_map="auto")
|
|
tokenizer = AutoTokenizer.from_pretrained(args.model_path)
|
|
model.eval()
|
|
model = accelerator.prepare(model)
|
|
|
|
# Load MT-Bench prompts from HuggingFace
|
|
ds = load_dataset("HuggingFaceH4/mt_bench_prompts")["train"]
|
|
ars = validate_ar(
|
|
model, tokenizer, ds, args.steps, args.osl, args.num_samples, accelerator.device
|
|
)
|
|
# Optionally, throw error if AR is below lower bound
|
|
if args.ar_lower_bound:
|
|
mean_ar = sum(ars) / len(ars)
|
|
if mean_ar < args.ar_lower_bound:
|
|
raise ValueError(
|
|
f"AR is below lower bound {args.ar_lower_bound}. Mean AR: {mean_ar:.4f}"
|
|
)
|
|
# Print results
|
|
if ars and accelerator.is_main_process:
|
|
avg_ar = sum(ars) / len(ars)
|
|
print("\n==== AR Validation Results on MT-Bench ====")
|
|
print(f"Number of samples: {len(ars)}")
|
|
print(f"Output Sequence Length: {args.osl}")
|
|
print(f"Steps: {args.steps}")
|
|
print(f"Average AR: {avg_ar:.4f}")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|