mirror of
https://github.com/NVIDIA/Model-Optimizer.git
synced 2026-11-02 08:03:22 +08:00
Keval Morabiaandh-guo18
80d2f02a2d
### What does this PR do? Type of change: Test fix <!-- Use one of the following: Bug fix, new feature, new example, new tests, documentation. --> - Fix `tests/examples/speculative_decoding` - previously silently skipped - Avoid pulling nemotron-post-training-dataset-v2 in tests to reduce chances of HF loading timeout in CICD - Make slow and redundant tests manual to speed up CICD ### Testing <!-- Mention how have you tested your change if applicable. --> - Tests passing ### Before your PR is "*Ready for review*" Make sure you read and follow [Contributor guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md) and your commits are signed (`git commit -s -S`). Make sure you read and follow the [Security Best Practices](https://github.com/NVIDIA/Model-Optimizer/blob/main/SECURITY.md#security-coding-practices-for-contributors) (e.g. avoiding hardcoded `trust_remote_code=True`, `torch.load(..., weights_only=False)`, `pickle`, etc.). - Is this change backward compatible?: ✅ <!--- If ❌, explain why. --> - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A <!--- Mandatory --> - Did you write any new necessary tests?: ✅ <!--- Mandatory for new features or examples. --> - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A <!--- Only for new features, API changes, critical bug fixes or backward incompatible changes. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Removed git‑LFS install step from CI and deleted an automated branch‑cleanup workflow * Trimmed example environment dependencies and relaxed transformers compatibility; added an optional tokenization dependency * **Tests** * Switched tests to generate datasets dynamically and improved fixture handling * Standardized PTQ test parameters (explicit calibration dataset) and refined GPU/test selection * **Bug Fixes** * Improved device-awareness and numeric handling in speculative decoding attention paths <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
76 lines
3.0 KiB
YAML
76 lines
3.0 KiB
YAML
# Reusable workflow for running example tests
|
|
name: Example Tests Runner
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
docker_image:
|
|
description: "Docker image to use for tests"
|
|
required: true
|
|
type: string
|
|
example:
|
|
description: "Example name to test (e.g. 'llm_ptq')"
|
|
required: true
|
|
type: string
|
|
timeout_minutes:
|
|
description: "Timeout in minutes for the job"
|
|
required: false
|
|
type: number
|
|
default: 60
|
|
pip_install_extras:
|
|
description: "Pip install extras (e.g. '[hf,dev-test]' or '[all,dev-test]')"
|
|
required: false
|
|
type: string
|
|
default: "[all,dev-test]"
|
|
runner:
|
|
description: "GitHub runner to use"
|
|
required: false
|
|
type: string
|
|
default: "linux-amd64-gpu-h100-latest-1"
|
|
|
|
jobs:
|
|
run-test:
|
|
runs-on: ${{ inputs.runner }}
|
|
timeout-minutes: ${{ inputs.timeout_minutes }}
|
|
container:
|
|
image: ${{ inputs.docker_image }}
|
|
options: --shm-size=2gb # TRT-LLM tests on 2-GPU runner needs more shared memory
|
|
env:
|
|
PIP_CONSTRAINT: "" # Disable pip constraint for upgrading packages
|
|
HF_TOKEN: ${{ secrets.HF_TOKEN }}
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
- uses: nv-gha-runners/setup-proxy-cache@main
|
|
- name: Setup environment variables
|
|
run: |
|
|
echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:/usr/include:/usr/lib/x86_64-linux-gnu:/usr/local/tensorrt/targets/x86_64-linux-gnu/lib" >> $GITHUB_ENV
|
|
echo "PATH=${PATH}:/usr/local/tensorrt/targets/x86_64-linux-gnu/bin" >> $GITHUB_ENV
|
|
- name: Install dependencies
|
|
run: |
|
|
# use `python -m pip` instead of `pip` to avoid conflicts with system pip for nemo containers
|
|
python -m pip install ".${{ inputs.pip_install_extras }}"
|
|
|
|
if [[ "${{ inputs.example }}" == *"diffusers"* ]]; then
|
|
echo "Uninstalling apex for diffusers: T5 Int8 (PixArt) + Apex is not supported as per https://github.com/huggingface/transformers/issues/21391"
|
|
python -m pip uninstall -y apex || true
|
|
fi
|
|
|
|
find examples/${{ inputs.example }} -name "requirements.txt" | while read req_file; do python -m pip install -r "$req_file" || exit 1; done
|
|
- name: Run tests
|
|
env:
|
|
# Absolute paths so subprocesses running from different working directories
|
|
# all find the config and write .coverage.* files to the same location.
|
|
COVERAGE_PROCESS_START: ${{ github.workspace }}/pyproject.toml
|
|
COVERAGE_FILE: ${{ github.workspace }}/.coverage
|
|
run: |
|
|
echo "Running tests for: ${{ inputs.example }}"
|
|
pytest tests/examples/${{ inputs.example }} --cov
|
|
- name: Upload coverage to Codecov
|
|
uses: codecov/codecov-action@v5
|
|
with:
|
|
token: ${{ secrets.CODECOV_TOKEN }}
|
|
files: coverage.xml
|
|
flags: examples
|
|
fail_ci_if_error: false # test may be skipped if relevant file changes are not detected
|
|
verbose: true
|