mirror of
https://github.com/NVIDIA/Model-Optimizer.git
synced 2026-11-01 07:53:10 +08:00
Chenhan D. Yu
248cbf2fd2
## Summary - Capture nemo-run experiment_id for Docker submit_job by redirecting detached launcher output to a side-channel log and tailing it briefly. - Reuse the launcher output parser for both Docker and Slurm submit paths. - Document Docker PID + experiment_id behavior and ignore the MCP local uv.lock. ## Jira OMNIML-5128 ## Validation - uv run --project tools/mcp pytest tools/mcp/tests -q <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved Docker job submission to capture `experiment_id` from launcher output during a brief tail window, while always returning the detached `pid` (and `stdout_log` diagnostics if capture times out). * Made Slurm identifier extraction more robust across varying launcher output formats. * **Documentation** * Updated `submit_job` docs/module descriptions to clarify Docker PID/`experiment_id` and `stdout_log` behavior on timeout. * **Tests** * Added/expanded tests for Docker success, timeout/no-id scenarios, parsing edge cases, and log-side-channel failure handling. * **Chores** * Updated local tooling ignore rules for `.venv/` and `uv.lock`. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Chenhan Yu <chenhany@nvidia.com>