mirror of
https://github.com/NVIDIA/Model-Optimizer.git
synced 2026-10-02 03:14:52 +08:00
### What does this PR do? - Add experimental support for transformers >=5.0 and remove deprecated usages: https://github.com/huggingface/transformers/blob/main/MIGRATION_GUIDE_V5.md - ⚠️ For accelerate examples that used `--warmup-ratio: float` (deprecated in 5.x), we now change it to `--warmup-steps: float | int` which works as ratio if float but only for 5.x. For 4.x, it will error out if float and prompt user to change back to `--warmup-ratio` or pass an int absolute step count. - ⚠️ Unified Hugging Face checkpoint export for quantized checkpoints may not work for some models with transformers>=5.0 yet as it requires a lot of fixes (e.g. change in how MoE experts are organized) - ~Add Workaround for TRT-LLM's import of deprecated transformers functions so trt-llm based gpu unit tests work fine. Still deployment for models needs proper fixes directly in TRT-LLM hence llm/vlm ptq example tests still run with transformers 4.57~ - Everything except PTQ and Export (mainly MoE) should work fine with transformers>=5.0 - Bump min torch to 2.8 and enable 2.11 cicd testing - NOTE: Upcoming Nemo:26.04 container comes with transformers 5.3 ### Testing <!-- Mention how have you tested your change if applicable. --> - [x] CI/CD tests passing - [x] Manually tested unit tests, gpu tests with transformers 4.56 and 5.4 - [x] Manually tested example tests (except trt-llm container tests) with transformers 4.56 and 5.4 - [x] 2-gpu nightly CICD tests manually triggered and passing: [gpu tests](https://github.com/NVIDIA/Model-Optimizer/actions/runs/23867257540), [example tests](https://github.com/NVIDIA/Model-Optimizer/actions/runs/23867260643) ### Before your PR is "*Ready for review*" Make sure you read and follow [Contributor guidelines](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md) and your commits are signed (`git commit -s -S`). Make sure you read and follow the [Security Best Practices](https://github.com/NVIDIA/Model-Optimizer/blob/main/SECURITY.md#security-coding-practices-for-contributors) (e.g. avoiding hardcoded `trust_remote_code=True`, using `torch.load(..., weights_only=True)`, avoiding `pickle`, etc.). - Is this change backward compatible?: ✅ <!--- If ❌, explain why. --> - If you copied code from any other source, did you follow IP policy in [CONTRIBUTING.md](https://github.com/NVIDIA/Model-Optimizer/blob/main/CONTRIBUTING.md#-copying-code-from-other-sources)?: N/A <!--- Mandatory --> - Did you write any new necessary tests?: ✅ <!--- Mandatory for new features or examples. --> - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: ✅ <!--- Only for new features, API changes, critical bug fixes or backward incompatible changes. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Make remote-code usage opt-in via a configurable --trust_remote_code flag across examples and tools. * **Bug Fixes** * Improve checkpoint/resume detection and related training guidance to avoid erroneous errors. * **Refactor** * Consolidate dtype/config naming, switch warmup settings from ratio → steps, and unify tokenizer invocation patterns. * **Documentation** * Simplify changelog title and add misc notes for release 0.44. * **Chores** * Remove scheduled PR-branch cleanup workflow and relax/remove several transformers version pins. * **Tests** * Adjust test gates, skips, and structures to align with updated deps and behaviors. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
124 lines
4.4 KiB
Python
124 lines
4.4 KiB
Python
# SPDX-FileCopyrightText: Copyright (c) 2023-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
# Copied and Adapted from https://github.com/huggingface/gpt-oss-recipes/blob/main/sft.py
|
|
# Copyright 2020-2025 The HuggingFace Team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""
|
|
accelerate launch \
|
|
--config_file configs/zero3.yaml \
|
|
sft.py \
|
|
--config configs/sft_full.yaml \
|
|
--model_name_or_path openai/gpt-oss-20b \
|
|
--packing true packing_strategy wrapped \
|
|
--run_name 20b-full-qat \
|
|
--attn_implementation kernels-community/vllm-flash-attn3
|
|
--quant_cfg MXFP4_MLP_WEIGHT_ONLY_CFG
|
|
"""
|
|
|
|
from transformers import AutoModelForCausalLM, AutoTokenizer, Mxfp4Config
|
|
from trl import (
|
|
ModelConfig,
|
|
ScriptArguments,
|
|
SFTConfig,
|
|
# SFTTrainer, Use ModelOpt's version instead
|
|
TrlParser,
|
|
)
|
|
from utils import (
|
|
get_original_huggingface_quant_method,
|
|
get_peft_config_for_moe,
|
|
is_distributed_job,
|
|
load_dataset_from_hub_or_local,
|
|
)
|
|
|
|
import modelopt.torch.opt as mto
|
|
|
|
# import ModelOpt's QATSFTTrainer instead of Huggingface TRL's SFTTrainer
|
|
from modelopt.torch.quantization.plugins import QATSFTTrainer, QuantizationArguments
|
|
|
|
# Enable automatic save/load of modelopt state huggingface checkpointing
|
|
mto.enable_huggingface_checkpointing()
|
|
|
|
|
|
def main(script_args, training_args, model_args, quant_args):
|
|
# ------------------------
|
|
# Load model & tokenizer
|
|
# ------------------------
|
|
model_kwargs = {
|
|
"revision": model_args.model_revision,
|
|
"trust_remote_code": model_args.trust_remote_code,
|
|
"attn_implementation": model_args.attn_implementation,
|
|
"dtype": getattr(model_args, "dtype", "bfloat16"),
|
|
"use_cache": not training_args.gradient_checkpointing,
|
|
}
|
|
|
|
if get_original_huggingface_quant_method(model_args.model_name_or_path) == "mxfp4":
|
|
model_kwargs["quantization_config"] = Mxfp4Config(dequantize=True)
|
|
|
|
if not is_distributed_job():
|
|
model_kwargs["device_map"] = "auto"
|
|
|
|
model = AutoModelForCausalLM.from_pretrained(model_args.model_name_or_path, **model_kwargs)
|
|
|
|
tokenizer = AutoTokenizer.from_pretrained(
|
|
model_args.model_name_or_path,
|
|
)
|
|
|
|
# --------------
|
|
# Load dataset
|
|
# --------------
|
|
dataset = load_dataset_from_hub_or_local(script_args, training_args)
|
|
|
|
# -------------
|
|
# Train model
|
|
# -------------
|
|
# Use ModelOpt's QATSFTTrainer instead of Huggingface TRL's SFTTrainer
|
|
trainer = QATSFTTrainer(
|
|
model=model,
|
|
args=training_args,
|
|
train_dataset=dataset[script_args.dataset_train_split],
|
|
eval_dataset=dataset[script_args.dataset_test_split]
|
|
if training_args.eval_strategy != "no"
|
|
else None,
|
|
processing_class=tokenizer,
|
|
peft_config=get_peft_config_for_moe(model, model_args),
|
|
quant_args=quant_args,
|
|
)
|
|
|
|
trainer.train()
|
|
trainer.save_model(training_args.output_dir)
|
|
if training_args.push_to_hub:
|
|
trainer.push_to_hub(dataset_name=script_args.dataset_name)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
parser = TrlParser((ScriptArguments, SFTConfig, ModelConfig, QuantizationArguments))
|
|
script_args, training_args, model_args, quant_args, _ = parser.parse_args_and_config(
|
|
return_remaining_strings=True
|
|
)
|
|
main(script_args, training_args, model_args, quant_args)
|