Commit Graph
7 Commits
Author SHA1 Message Date
Alexander Brown b729e9a7b6 Fix equivalence verifier gaps and select replacements by cnr_id only
Move the verifier into its test module and run it over registered
equivalent entries; handle V3 combos, control widgets on combo and
float inputs, required inputs the server swap leaves empty, and the
frontend's float rounding. Drop aux_id matching, which never equals a
cnr_id, to match the frontend.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1f755-2724-7319-8506-c3df0b0c488a
2026-11-20 05:15:18 +00:00
Alexander Brown d63aaa9501 Add pack identity and kind to node replacements, with an equivalence verifier
NodeReplace gains old_pack (the cnr_id of the pack defining old_node_id) and
kind ("deprecated" or "equivalent"). Equivalent entries must name old_pack, so a
pack node type only maps to core when the workflow node came from that pack.

NodeReplaceManager dedupes on (new_node_id, old_pack) and selects a replacement
by the prompt node's _meta.cnr_id / aux_id: exact pack first, then a pack-less
entry; a node without pack identity only takes a pack entry when every entry
names the same pack.

app/node_equivalence.py checks that an equivalent entry is lossless against the
old and new /object_info schemas: every widget mapped in saved order, types and
ranges contained, FLOAT precision not coarser, dynamicPrompts matching, outputs
mapped to the same type, and no set_value over a mapped input. Tests run it
against ComfyUI-KJNodes snapshots and the live core primitive schemas.

Amp-Thread-ID: https://ampcode.com/threads/T-d0d41b9b-d42b-4824-9347-136f32b45608
2026-11-20 03:43:15 +00:00
Jukka Seppänen 6b904b5faf Add TextGenerateV2 with Autogrow image inputs (#17492) 2026-11-02 19:36:45 -05:00
guill 3d9b2d5517 Add governance enforcement for custom nodes (#16167) 2026-10-06 16:45:35 -07:00
Jedrzej Kosinski c8673542f7 fix: make NodeReplaceManager.register() idempotent (#13596) 2026-05-07 19:21:12 -07:00
Jedrzej Kosinski 33f83d53ae Fix KeyError when prompt entries lack class_type key (#12595)
Skip entries in the prompt dict that don't contain a class_type key
in apply_replacements(), preventing crashes on metadata or non-node
entries.

Fixes Comfy-Org/ComfyUI#12517
2026-02-24 16:02:05 -05:00
Jedrzej Kosinski 596ed68691 Node Replacement API (#12014) 2026-02-15 02:12:30 -08:00